[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zachsmith1
Once this PR has been reviewed and has the lgtm label, please assign jeremyot for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f)
• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f, 1db63bc)
• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f, 1db63bc, ed2a440)
• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f, 1db63bc, ed2a440, 0abdcad)
• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f, 1db63bc, ed2a440, 0abdcad, 1493d97)
• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f, 1db63bc, ed2a440, 0abdcad, 1493d97, 8c521f9)
• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f, 1db63bc, ed2a440, 0abdcad, 1493d97, 8c521f9, 434aeb5)
• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f, 1db63bc, ed2a440, 0abdcad, 1493d97, 8c521f9, 434aeb5, c1bd6b3)
• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f, 1db63bc, ed2a440, 0abdcad, 1493d97, 8c521f9, 434aeb5, c1bd6b3, 0a6a229)
• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f, 1db63bc, ed2a440, 0abdcad, 1493d97, 8c521f9, 434aeb5, c1bd6b3, 0a6a229, 335a35b)
• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f, 1db63bc, ed2a440, 0abdcad, 1493d97, 8c521f9, 434aeb5, c1bd6b3, 0a6a229, 335a35b, 83c6d32)
• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f, 1db63bc, ed2a440, 0abdcad, 1493d97, 8c521f9, 434aeb5, c1bd6b3, 0a6a229, 335a35b, 83c6d32, 9181aba)
• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f, 1db63bc, ed2a440, 0abdcad, 1493d97, 8c521f9, 434aeb5, c1bd6b3, 0a6a229, 335a35b, 83c6d32, 9181aba, 8015825)
• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f, 1db63bc, ed2a440, 0abdcad, 1493d97, 8c521f9, 434aeb5, c1bd6b3, 0a6a229, 335a35b, 83c6d32, 9181aba, 8015825, 9588d26)
• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f, 1db63bc, ed2a440, 0abdcad, 1493d97, 8c521f9, 434aeb5, c1bd6b3, 0a6a229, 335a35b, 83c6d32, 9181aba, 8015825, 9588d26, 8b9beaf)
• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f, 1db63bc, ed2a440, 0abdcad, 1493d97, 8c521f9, 434aeb5, c1bd6b3, 0a6a229, 335a35b, 83c6d32, 9181aba, 8015825, 9588d26, 8b9beaf, 2b5537a)
• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f, 1db63bc, ed2a440, 0abdcad, 1493d97, 8c521f9, 434aeb5, c1bd6b3, 0a6a229, 335a35b, 83c6d32, 9181aba, 8015825, 9588d26, 8b9beaf, 2b5537a, 5bd7f9b)
• ✅login: zachsmith1 / name: Zach Smith / (f3ea62f, 1db63bc, ed2a440, 0abdcad, 1493d97, 8c521f9, 434aeb5, c1bd6b3, 0a6a229, 335a35b, 83c6d32, 9181aba, 8015825, 9588d26, 8b9beaf, 2b5537a, 5bd7f9b, 31c2794)

Welcome @zachsmith1!

It looks like this is your first PR to kubernetes-sigs/multicluster-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/multicluster-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

this looks amazing 🚀

with this implementation, is it possible to shard individual clusters too or is it per cluster?

this looks amazing 🚀

with this implementation, is it possible to shard individual clusters too or is it per cluster?

This is just for clusters but I think there is another community project we could leverage for the intra cluster sharding